Skip to content

Conversation

@zherr
Copy link
Contributor

@zherr zherr commented May 6, 2016

RefTagID does not appear on BusinessMessageReject type, and should not have it set.

I don't see coverage of in_session.go which uses doReject. Open approaches on that.

@mgatny
Copy link
Member

mgatny commented May 6, 2016

LGTM

@cbusbey
Copy link
Contributor

cbusbey commented May 6, 2016

💪 🐴

@cbusbey cbusbey merged commit 66b8da5 into quickfixgo:master May 6, 2016
@cbusbey cbusbey added the Bug Behavior not matching expected label May 6, 2016
@cbusbey cbusbey added this to the v0.3.0 milestone May 6, 2016
@zherr zherr deleted the refTagReject branch May 6, 2016 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Behavior not matching expected

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants